Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instruction::branch_i64_{eqz,nez} instructions #797

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Add Instruction::branch_i64_{eqz,nez} instructions #797

merged 4 commits into from
Nov 24, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Nov 24, 2023 •
edited
Loading

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0		 1.55ms 1.56ms ⚪ 0.32% 1.15ms 1.12ms 🔴 -2.95% 🟢 -28%
execute/
bare_call_0/typed		 1.17ms 1.15ms ⚪ -1.41% 807.92µs 825.44µs 🔴 2.08% 🟢 -29%
execute/
bare_call_1		 1.60ms 1.62ms 🔴 0.77% 1.35ms 1.24ms 🔴 -8.35% 🟢 -23%
execute/
bare_call_16		 2.59ms 2.55ms 🔴 -1.55% 3.40ms 3.39ms ⚪ -0.18% 🟢 33%
execute/
bare_call_16/typed		 1.56ms 1.60ms 🔴 2.84% 1.93ms 1.93ms ⚪ 0.06% 🟢 20%
execute/
bare_call_1/typed		 1.26ms 1.25ms ⚪ -0.03% 1.08ms 1.20ms 🔴 10.46% 🟢 -4%
execute/
bare_call_4		 1.77ms 1.79ms 🔴 -0.18% 1.72ms 1.67ms 🟢 -3.25% 🟢 -7%
execute/
bare_call_4/typed		 1.22ms 1.29ms 🔴 6.13% 1.06ms 1.05ms ⚪ -1.01% 🟢 -19%
execute/
br_table		 1.47ms 1.35ms 🟢 -7.70% 1.18ms 1.18ms ⚪ -0.48% 🟢 -13%
execute/
count_until		 5.46ms 5.46ms ⚪ -0.14% 17.15ms 16.74ms 🟢 -2.36% 🔴 207%
execute/
factorial_iterative		 319.67µs 321.10µs ⚪ 0.40% 793.42µs 803.30µs ⚪ 1.11% 🔴 150%
execute/
factorial_recursive		 493.97µs 493.25µs ⚪ -0.20% 971.16µs 971.90µs ⚪ 0.05% 🟡 97%
execute/
fibonacci_iter		 1.40ms 1.40ms ⚪ 0.25% 3.82ms 3.84ms ⚪ 0.40% 🔴 174%
execute/
fibonacci_rec		 3.98ms 3.97ms ⚪ -0.30% 8.59ms 8.57ms ⚪ -0.19% 🔴 116%
execute/
fibonacci_tail		 856.50µs 856.05µs ⚪ 0.00% 2.20ms 2.17ms 🟢 -1.26% 🔴 154%
execute/
fuse		 10.61ms 10.61ms ⚪ -0.03% 34.55ms 34.15ms 🟢 -1.21% 🔴 222%
execute/
global_bump		 748.11µs 741.74µs ⚪ -0.95% 2.18ms 2.25ms ⚪ 1.64% 🔴 203%
execute/
global_const		 659.58µs 660.90µs ⚪ 0.17% 2.44ms 2.43ms ⚪ -0.43% 🔴 267%
execute/
host_calls		 36.21µs 36.38µs ⚪ 0.47% 39.86µs 40.24µs ⚪ 0.87% 🟢 11%
execute/
memory_fill		 1.15ms 1.21ms 🔴 5.61% 3.32ms 3.30ms ⚪ -0.63% 🔴 172%
execute/
memory_sum		 1.14ms 1.24ms 🔴 6.61% 3.29ms 3.30ms ⚪ 0.03% 🔴 167%
execute/
memory_vec_add		 2.35ms 2.35ms ⚪ 0.01% 7.55ms 7.34ms 🟢 -2.77% 🔴 213%
execute/
recursive_is_even		 663.90µs 662.44µs ⚪ -0.24% 1.45ms 1.45ms ⚪ 0.42% 🔴 119%
execute/
recursive_ok		 94.45µs 95.33µs ⚪ 0.88% 199.03µs 208.67µs ⚪ 5.30% 🔴 119%
execute/
recursive_scan		 129.25µs 130.72µs 🔴 1.11% 284.12µs 287.80µs ⚪ 1.18% 🔴 120%
execute/
recursive_trap		 8.82µs 8.80µs ⚪ -0.26% 21.00µs 20.86µs ⚪ -0.42% 🔴 137%
execute/
regex_redux		 455.89µs 460.92µs ⚪ 1.06% 1.23ms 1.26ms 🔴 1.95% 🔴 174%
execute/
rev_complement		 423.91µs 421.25µs ⚪ -0.47% 1.14ms 1.18ms 🔴 3.47% 🔴 180%
execute/
tiny_keccak		 321.96µs 331.98µs 🔴 3.14% 1.10ms 1.15ms 🔴 5.25% 🔴 248%
execute/
trunc_f2i		 737.93µs 732.10µs ⚪ -0.79% 1.71ms 1.72ms ⚪ 0.12% 🔴 134%
instantiate/
wasm_kernel		 56.95µs 54.05µs 🟢 -4.74% 57.14µs 58.14µs ⚪ 1.69% 🟢 8%
translate/
erc1155		 207.74µs 209.91µs ⚪ 1.19% 362.87µs 367.89µs ⚪ 1.58% 🟡 75%
translate/
erc20		 102.66µs 104.36µs 🔴 1.76% 176.46µs 175.30µs ⚪ -1.06% 🟡 68%
translate/
erc721		 146.20µs 147.36µs ⚪ 0.94% 255.80µs 254.39µs ⚪ -0.64% 🟡 73%
translate/
spidermonkey		 64.36ms 64.57ms ⚪ 0.28% 0.00ns 0.00ns ⚪ -0.29% 🟢 -100%
translate/
wasm_kernel		 4.26ms 4.27ms ⚪ 0.29% 6.59ms 6.57ms ⚪ -0.11% 🟡 54%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (91a956b) 81.13% compared to head (50907db) 81.08%.

Files Patch % Lines
...smi/src/engine/regmach/translator/instr_encoder.rs 61.76% 13 Missing ⚠️
...wasmi/src/engine/regmach/executor/instrs/branch.rs 60.00% 8 Missing ⚠️
.../wasmi/src/engine/regmach/translator/result_mut.rs 0.00% 4 Missing ⚠️
...mi/src/engine/regmach/translator/visit_register.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   81.13%   81.08%   -0.05%     
==========================================
  Files         274      274              
  Lines       25271    25323      +52     
==========================================
+ Hits        20503    20533      +30     
- Misses       4768     4790      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 5bea360 into master Nov 24, 2023
13 checks passed
@Robbepop Robbepop deleted the rf-fuse-i64.eqz+br_if branch November 24, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robbepop @paritytech-cicd-pr @codecov-commenter